[release-1.14] Fixed issue where jobs with subgroups but not hard networkTopology.mode could not be scheduled.

[volcano-sh-bot]

This is an automated cherry-pick of #5038

NONE

[gemini-code-assist]

Summary of Changes

Hello @volcano-sh-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where jobs configured with subgroup policies failed to schedule if they lacked an explicit hard network topology mode. The changes extend the core job allocation logic to properly recognize and schedule such jobs, ensuring that subgroup policies are respected independently of network topology constraints. This enhancement improves the robustness and flexibility of the scheduler for complex job configurations.

Highlights

• Enhanced Job Allocation Logic: The scheduler's job allocation mechanism has been updated to correctly process jobs that define SubJobPolicy even when they do not explicitly specify a hard network topology mode, resolving a previous scheduling limitation.
• Refined Test Utility Functions: Helper functions used for constructing SubGroupPolicy and PodGroup objects in tests were modified to ensure that network topology specifications are only applied when a mode is explicitly provided, preventing unintended default behavior.
• Improved Test Coverage: New unit and end-to-end tests have been introduced to validate that jobs with subgroup policies can be successfully scheduled without requiring a hard network topology configuration, ensuring the fix works as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/scheduler/actions/allocate/allocate.go
  • Extended the condition for calling allocateForJob to include jobs with ContainsSubJobPolicy() in addition to ContainsHardTopology().
  • Added comments to clarify that allocateForJob is now used for both hard-mode network topology scheduling and subjob level scheduling.
• pkg/scheduler/actions/allocate/allocate_test.go
  • Added a new test case named "no network topology at job or subgroup level but has SubJobPolicy, can allocate job successfully" to validate the updated allocation logic.
• pkg/scheduler/util/test_utils.go
  • Modified BuildSubGroupPolicyWithMinSubGroups to conditionally set the NetworkTopology field only if a mode is provided.
  • Updated BuildPodGroupWithSubGroupPolicy to conditionally call BuildPodGroupWithNetWorkTopologies or BuildPodGroup based on whether a network topology mode is specified.
  • Updated comments for BuildSubGroupPolicyWithMinSubGroups and BuildPodGroupWithSubGroupPolicy to reflect the conditional setting of network topology.
• test/e2e/schedulingaction/allocate.go
  • Imported batchv1alpha1 for batch API types.
  • Added a new end-to-end test case to verify that jobs with partition policies but no network topology constraints can be successfully allocated.

Activity

• This pull request is an automated cherry-pick of an upstream fix (Fixed issue where jobs with subgroups but not hard networkTopology.mode could not be scheduled. #5038).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where jobs with subgroups defined via SubJobPolicy but without a hard network topology constraint were not being scheduled correctly. The fix modifies the allocation logic to route such jobs to the allocateForJob function, which is designed to handle sub-job scheduling. This change is well-supported by the addition of a new unit test and an end-to-end test that specifically cover this scenario. The test utilities have also been updated to facilitate these new tests. The fix is correct, targeted, and effectively resolves the issue.

[JesseStutler]

/approve
/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JesseStutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JesseStutler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment