Fixed issue where jobs with subgroups but not hard networkTopology.mode could not be scheduled.

[JesseStutler]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When networkTopology.mode is not hard, but subgroups exist, scheduling is not possible, we need to support it.
This pr is inherited from #4872

Which issue(s) this PR fixes:

Fixes #4871

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[gemini-code-assist]

Summary of Changes

Hello @JesseStutler, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the scheduler where jobs configured with subgroups were unable to be scheduled if they did not also specify a hard network topology mode. The changes update the allocation logic to properly account for jobs with subjob policies, allowing them to proceed through the scheduling process as intended. This ensures greater flexibility and correctness in how jobs with complex structures are handled by the system.

Highlights

• Bug Fix: Subgroup Scheduling: Resolved an issue preventing jobs with subgroups from being scheduled when networkTopology.mode was not set to hard.
• Logic Update for Job Allocation: Modified the scheduling logic to correctly identify and process jobs that have subjob policies, ensuring they are considered for allocation even without explicit hard network topology constraints.
• Test Case Added: Introduced a new test case to validate that jobs with subjob policies can be successfully allocated, even if they lack a hard network topology configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/scheduler/actions/allocate/allocate.go
  • Updated comment for tasksNoHardTopology to include jobs with subjob policies.
  • Modified job processing conditions to include jobs with subjob policies alongside those without hard network topology for tasksNoHardTopology assignment.
  • Extended the condition for calling allocateForJob to include jobs with subjob policies, ensuring proper resource allocation for these job types.
  • Updated logging messages to reflect the inclusion of subjob policies in allocation considerations.
• pkg/scheduler/actions/allocate/allocate_test.go
  • Added a new test case to verify successful allocation for jobs with subjob policies but no hard network topology.

Activity

• The pull request was created to fix issue When networkTopology.mode is not hard, but subgroups exist, scheduling is not possible. #4871, addressing a bug where jobs with subgroups could not be scheduled without hard network topology.
• The changes are inherited from a previous pull request, Fixed issue where jobs with subgroups but not hard networkTopology.mode could not be scheduled. #4872, indicating a continuation or refinement of an existing fix.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[JesseStutler]

Let me also add e2e tests and further verify it

[gemini-code-assist]

Code Review

This pull request successfully addresses an issue where jobs with subgroups but without a hard network topology mode were not being scheduled correctly. The fix correctly routes jobs with sub-job policies to the allocateForJob function, which is capable of handling them. The addition of a new test case ensures this scenario is now covered. I have a couple of suggestions to refine the logic for populating tasksNoHardTopology to improve efficiency and code clarity.

[Copilot]

Pull request overview

Fixes a scheduling failure in the allocate action for jobs that have subgroups (SubGroupPolicy/subjobs) when networkTopology.mode is not hard, by ensuring those jobs use the subjob-aware allocation path.

Changes:

• Route jobs with SubGroupPolicy through allocateForJob (same path as hard-topology jobs) instead of the default-subjob-only path.
• Update tasksNoHardTopology comments/initialization to reflect the adjusted scheduling paths.
• Add a regression test covering allocation when subgroups exist without hard topology at the job level.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/scheduler/actions/allocate/allocate.go	Uses allocateForJob for subjob-policy jobs to avoid default-subjob lookups that can fail when real subjobs exist.
pkg/scheduler/actions/allocate/allocate_test.go	Adds a test case to ensure subjob-policy jobs can be allocated without hard job-level topology.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[JesseStutler]

Now the vcjob without network topology but with subjob can be scheduled:

[JesseStutler]

/cc @ouyangshengjia @hzxuzhonghu

[hzxuzhonghu]

Thank you for the fix

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hzxuzhonghu]

/cherry-pick release-1.14

[volcano-sh-bot]

@hzxuzhonghu: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hzxuzhonghu]

/lgtm

[volcano-sh-bot]

@hzxuzhonghu: new pull request created: #5041

Details

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ouyangshengjia]

/lgtm