test(install): cargo install --path honors MSRV - #17102
Merged
Merged
Conversation
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ehuss
reviewed
Jun 15, 2026
| } | ||
|
|
||
| /// `cargo install --path` builds a normal workspace, | ||
| /// so its dependency resolution honors |
Contributor
There was a problem hiding this comment.
Not sure if this was an incomplete sentence?
Suggested change
| /// so its dependency resolution honors | |
| /// so its dependency resolution honors msrv. |
Member
Author
There was a problem hiding this comment.
Somehow dropped it during the edit. Thanks for the catch. Fixed.
weihanglo
force-pushed
the
msrv-install-path
branch
from
June 15, 2026 15:14
a4f7eb7 to
f9749c6
Compare
ehuss
approved these changes
Jun 15, 2026
ehuss
enabled auto-merge
June 15, 2026 15:44
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 15, 2026
ehuss
enabled auto-merge
June 15, 2026 16:03
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jun 17, 2026
Update cargo submodule 7 commits in fe63976b245b8a649c3f2949bf89fdc307bfbae4..598ab48ec328e3e4f5e4e373d8df7264bc8e27cd 2026-06-11 09:17:57 +0000 to 2026-06-17 02:39:50 +0000 - Improved the test error messages when 'rustc -V' fails (rust-lang/cargo#17108) - test(install): `cargo install` --path honors MSRV (rust-lang/cargo#17102) - feat(trim-paths): emit `CARGO_TRIM_PATHS_REMAP` for build.rs (rust-lang/cargo#17104) - Add funding links (rust-lang/cargo#17103) - fix(diag): Give diagnostics the same display path behavior as rustc (rust-lang/cargo#17101) - refactor: remove cargo-util-terminal from bump-check exclusions (rust-lang/cargo#17098) - fix(diag): Report all errors, in order (rust-lang/cargo#17095)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This doesn't seem to be covered by existing test suite.
Found when working on min-publish-age.