fix(diag): Report all errors, in order#17095
Merged
Merged
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This makes the two existing passes more consistent. The downside is that if there is an error, that might not be the final message. This is the case with `--keep-going` (see https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/.60--keep-going.60.20and.20compilation.20errors/near/595741468). We may want to iterate on this further and make stop after the current manifest/package unless `--keep-going` is provided.
20 tasks
weihanglo
approved these changes
Jun 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 12, 2026
Member
|
GitHub Actions is not working properly (I believe). See #t-cargo > [16] Error in the HTTP2 framing layer Requeuing. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 12, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jun 17, 2026
Update cargo submodule 7 commits in fe63976b245b8a649c3f2949bf89fdc307bfbae4..598ab48ec328e3e4f5e4e373d8df7264bc8e27cd 2026-06-11 09:17:57 +0000 to 2026-06-17 02:39:50 +0000 - Improved the test error messages when 'rustc -V' fails (rust-lang/cargo#17108) - test(install): `cargo install` --path honors MSRV (rust-lang/cargo#17102) - feat(trim-paths): emit `CARGO_TRIM_PATHS_REMAP` for build.rs (rust-lang/cargo#17104) - Add funding links (rust-lang/cargo#17103) - fix(diag): Give diagnostics the same display path behavior as rustc (rust-lang/cargo#17101) - refactor: remove cargo-util-terminal from bump-check exclusions (rust-lang/cargo#17098) - fix(diag): Report all errors, in order (rust-lang/cargo#17095)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This makes the two existing passes more consistent.
The downside is that if there is an error, that might not be the final message.
This is already the case with
--keep-going(see #t-cargo > `--keep-going` and compilation errors @ 💬).We may want to iterate on this further and stop after the current manifest/package unless
--keep-goingis provided.How to test and review this PR?