Escape examples for role="time"#1638
Conversation
|
The line above the list reads:
I think the change would make this less clear. Readers would need to know the On the other hand, these examples lack an example wrapper (class="example") and the section could probably use some work in general. |
|
|
|
Right, sorry for having been unclear. I mixed my first and second point. I find this whole "example" confusing. Usually, examples in the spec are marked up separately and present code samples. If this is supposed to be such a code example, then I'm not sure what it's covering. If it's just about strings, there's no need for any markup. If it's about role=time markup, the current markup seems better -- but needs to be escaped. Not sure I'm making more sense now. |
This reverts commit 3ba0825.
|
Escaping sounds good so I just did that, hope that's more clear now. |
There was a problem hiding this comment.
thanks @saschanaz, this helps!
edit: nm on that editorial issue. bigger things to worry about.
role="time" for nowrole="time"
|
Thanks @saschanaz ! |
|
ping @jnurthen |
* escape * aside class=example
Fixes another issue from #1623
Not sure whether using
role="time"in the definition ofrole="time"makes sense, but please tell me if it actually does.Preview | Diff