fix: correct typos in scheduler comments#5328
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects typos in scheduler-related comments without changing runtime behavior.
Changes:
- Fixed spelling in comments for CPU manager, deviceshare, vnpu, and agentscheduler cache code.
- Keeps the changes limited to comment-only cleanup as described.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pkg/scheduler/plugins/numaaware/provider/cpumanager/cpu_mng.go |
Corrects resourc-exporter to resource-exporter in a comment. |
pkg/scheduler/plugins/deviceshare/deviceshare.go |
Corrects seperate to separate in a TODO comment. |
pkg/scheduler/api/devices/ascend/mindcluster/ascend310p/vnpu/type.go |
Corrects schduled to scheduled in a status comment. |
pkg/agentscheduler/cache/cache.go |
Corrects seperate to separate in cache-related comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request corrects several typos in code comments across multiple files, specifically fixing misspellings of 'separate', 'scheduled', and 'resource-exporter'. Review feedback suggests additional refinements to the grammar and capitalization in these comments to enhance clarity and maintain consistency with naming conventions.
| NodedNodeHealtyStatuskey = "nodedNodeHealtyStatus" | ||
| // NodeSubHealthy means there is some fault on the node which is reported by nodeD, but will not immediately | ||
| // make node unhealthy, this status will prevent new task schduled on this node and reschedule will not consider | ||
| // make node unhealthy, this status will prevent new task scheduled on this node and reschedule will not consider |
There was a problem hiding this comment.
The grammar in this comment could be improved for better clarity and professionalism. Using the plural tasks and the gerund rescheduling makes the sentence more natural.
| // make node unhealthy, this status will prevent new task scheduled on this node and reschedule will not consider | |
| // make node unhealthy; this status will prevent new tasks from being scheduled on this node, and rescheduling will not consider |
|
|
||
| // getPhysicalCoresNum return the number of physical cores. | ||
| // The resourc-exporter reports core ids only unique in each socket, | ||
| // The resource-exporter reports core ids only unique in each socket, |
There was a problem hiding this comment.
Capitalizing IDs is more consistent with the naming conventions used in the surrounding code (e.g., CoreID and SocketID in the function below). The phrasing is also slightly adjusted for better clarity.
| // The resource-exporter reports core ids only unique in each socket, | |
| // The resource-exporter reports core IDs that are only unique within each socket, |
Signed-off-by: pmady <pavan4devops@gmail.com>
e785081 to
bdc686e
Compare
|
/ok-to-test |
|
e2e-sequence failure is unrelated to this PR, the cleanup hook in could you re-run the failed job? thanks @archlitchi |
|
@pmady Totally fine, merge now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fixes a few typos I noticed while reading through the scheduler code:
seperate→separatein deviceshare and agentscheduler cacheresourc-exporter→resource-exporterin cpu_mng.goschduled→scheduledin vnpu type.goWhich issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Comment-only changes, no logic changes.
Does this PR introduce a user-facing change?
NONE