[release-1.12] Fix: Changes to task members in a PodGroup caused task validity checks to fail during scheduling

[volcano-sh-bot]

This is an automated cherry-pick of #4803

NONE

[gemini-code-assist]

Summary of Changes

Hello @volcano-sh-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the scheduler's JobInfo processing where modifications to task members within a PodGroup were not properly reflected, leading to failed task validity checks during scheduling. The fix involves ensuring that the TaskMinAvailable map is cleared before being repopulated, thereby guaranteeing that the scheduler always operates with the most current and accurate task member configurations. This change is a cherry-pick from an upstream fix.

Highlights

• Bug Fix: Resolved an issue where changes to task members within a PodGroup were not correctly processed, leading to failed task validity checks during scheduling.
• Data Integrity: Implemented a clear operation for the TaskMinAvailable map in ParseMinMemberInfo to ensure it is reset before being populated with new PodGroup task member configurations, preventing stale data from affecting scheduling decisions.
• Test Coverage: Added a new comprehensive unit test, TestParseMinMemberInfoChanged, to validate the correct behavior of ParseMinMemberInfo across various scenarios involving modifications to PodGroup task members.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where changes to task members in a PodGroup were not correctly reflected in the JobInfo, leading to potential task validity check failures during scheduling. The fix is to clear the TaskMinAvailable map before it's repopulated from the PodGroup spec. This ensures that stale entries from a previous state are removed. A new suite of table-driven unit tests has been added to verify the fix under various scenarios of MinTaskMember changes. The changes are correct and the testing is thorough.

[JesseStutler]

/approve
/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JesseStutler
Once this PR has been reviewed and has the lgtm label, please assign lowang-bh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment