Skip to content

devtools: Replace new with register for PageStyleActor#44068

Merged
eerii merged 2 commits into
servo:mainfrom
elomscansio:register-pagestyle-actor
Apr 9, 2026
Merged

devtools: Replace new with register for PageStyleActor#44068
eerii merged 2 commits into
servo:mainfrom
elomscansio:register-pagestyle-actor

Conversation

@elomscansio

Copy link
Copy Markdown
Contributor

Added a register method to PageStyleActor following the same pattern used by other actors in the devtools codebase. Updated InspectorActor::register to use it instead of constructing PageStyleActor directly.

Testing:
Ran ./mach try linux-unit-tests and ./mach test-devtools. No new failures introduced.

Fixes:part of #43800

Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 9, 2026

@eerii eerii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@servo-highfive servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 9, 2026
Signed-off-by: eri <eri@igalia.com>
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Apr 9, 2026
@eerii
eerii enabled auto-merge April 9, 2026 14:03
@eerii
eerii added this pull request to the merge queue Apr 9, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 9, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 9, 2026
@eerii
eerii added this pull request to the merge queue Apr 9, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 9, 2026
Merged via the queue into servo:main with commit 11cea2f Apr 9, 2026
39 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants