Skip to content

Rewrite tuple_array_conversions#17354

Merged
llogiq merged 1 commit into
rust-lang:masterfrom
Jarcho:tuple_array
Jul 5, 2026
Merged

Rewrite tuple_array_conversions#17354
llogiq merged 1 commit into
rust-lang:masterfrom
Jarcho:tuple_array

Conversation

@Jarcho

@Jarcho Jarcho commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This cannot be broken down into useful smaller commits as basically none of the original approach really exists and nothing had a one-to-one replacements. Changes include:

  • Separate the code for handling the destructured and accessor forms.
  • Match the HIR tree more before accessing other data.
  • Remove unnecessary allocations.
  • Slightly better macro handling.
  • Don't visit multiple times when checking binding uses.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 4, 2026
@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 8 candidates
  • 8 candidates expanded to 8 candidates
  • Random selection from llogiq, samueltardieu

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Lintcheck changes for 7d3160c

Lint Added Removed Changed
clippy::tuple_array_conversions 1 1 0

This comment will be updated if you push new changes

* Separate the code for handling the destructured and accessor forms.
* Match the HIR tree more before accessing other data.
* Remove unnecessary allocations.
* Slightly better macro handling.
* Don't visit multiple times when checking binding uses.

@llogiq llogiq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

View changes since this review

@llogiq
llogiq added this pull request to the merge queue Jul 5, 2026
Merged via the queue into rust-lang:master with commit add4b9f Jul 5, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants