perf: skip the HIR parent walk in is_in_test_function when there are no test items#17224
Merged
Merged
Conversation
Contributor
Author
xmakro
marked this pull request as ready for review
June 13, 2026 14:57
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? clippy |
Contributor
|
r? @llogiq Sorry for the delay, I'm on it. |
llogiq
approved these changes
Jun 30, 2026
| && let ItemKind::Fn { ident, .. } = item.kind | ||
| { | ||
| // Note that we have sorted the item names in the visitor, | ||
| // so the binary_search gets the same as `contains`, but faster. |
Contributor
There was a problem hiding this comment.
That's underestimating the efficiency of a linear search. At least if there are only a few test functions in the module, linear search can actually be faster. Not that it matters, in those cases both are sufficiently speedy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: none