Fix implicit_saturating_sub suggests wrongly on untyped int literal#16309
Merged
Conversation
Collaborator
Jarcho
approved these changes
Jan 1, 2026
Member
Author
|
Thank you and happy new year! |
pull Bot
pushed a commit
to Mattlk13/rust-clippy
that referenced
this pull request
Jul 13, 2026
… { x -= 1 }` rewrite (rust-lang#17404)
Fixes rust-lang#17403
`implicit_saturating_sub` rewrites `if x != 0 { x -= 1 }` into `x =
x.saturating_sub(1)`. `saturating_sub` is only usable in a `const fn`
since Rust 1.47, so in a `const fn` with a lower configured MSRV the
rewrite does not compile.
rust-lang#16309 already added this MSRV check to the `if a
>= b { 0 } else { b - a }` path, but the condition path (`if x != 0 { x
-= 1 }`) was left unguarded. This threads the MSRV into that path and
applies the same check, so the lint stays quiet when the suggested
`saturating_sub` would be too new for the const context.
The lint reads the MSRV but was missing from the list of MSRV affected
lints in the configuration docs, so this registers it there as well.
changelog: [`implicit_saturating_sub`]: respect the configured MSRV in
const contexts for the `if x != 0 { x -= 1 }` rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16307
changelog: [
implicit_saturating_sub] fix wrong suggestions on untyped int literal