chore: dockerize browser tests - #598
Merged
Merged
Conversation
kellyjosephprice
force-pushed
the
chore/dockerize-browser-tests
branch
from
October 17, 2022 21:32
fa473c7 to
3568f3b
Compare
|
A review app has been launched for this PR!
|
kellyjosephprice
requested review from
a team,
ellierossuck,
erunion and
thenaomiday
and removed request for
a team
October 17, 2022 22:09
kellyjosephprice
marked this pull request as ready for review
October 17, 2022 22:09
ellierossuck
approved these changes
Oct 17, 2022
ellierossuck
left a comment
Contributor
There was a problem hiding this comment.
YES PLEASE! This is an awesome change, I always forgot where to find the snapshots within the GH actions UI, it was very confusing to me
rafegoldberg
pushed a commit
that referenced
this pull request
Oct 20, 2022
## Version 6.53.1 ### 📘 Tests & Docs * add link for emoji list ([#547](#547)) ([bab15ff](bab15ff)) ### 🛠 Fixes & Updates * **deps-dev:** bump @testing-library/react from 12.1.2 to 12.1.5 ([#504](#504)) ([a9ffb70](a9ffb70)) * **deps:** bump npm from 8.10.0 to 8.13.2 ([#533](#533)) ([3ca6ac8](3ca6ac8)) * **deps:** bump nth-check from 2.0.0 to 2.0.1 ([#444](#444)) ([67191cd](67191cd)) * **deps:** bump scss-tokenizer from 0.3.0 to 0.4.3 ([#596](#596)) ([d91f5da](d91f5da)) * **deps:** bump semver-regex from 3.1.2 to 3.1.4 ([#497](#497)) ([3171fcb](3171fcb)) * **deps:** bump undici from 5.8.0 to 5.9.1 ([#572](#572)) ([5028530](5028530)) * dockerize browser tests ([#598](#598)) ([c6a43ee](c6a43ee)) ### ✨ New & Improved * **glossary:** dark mode ([#599](#599)) ([6d9e7eb](6d9e7eb)) <!--SKIP CI-->
Collaborator
|
This PR was released!🚀 Changes included in v6.53.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Dockerize browser tests so people can run them locally.
The snapshot tests are pretty environment specific. CI typically uses ubuntu and most of the devs are running OSX. I believe a bunch of time was spent trying to get the font config to match, but it didn't quite work? So this re-opens an old PR that runs the snapshot tests in a docker container.
Prior to this, the workflow had been:
Now, if you're clever, you can run the tests before updating the branch. Or, more likely, not have to dig the github actions UI to download the snapshots, and instead generate them locally.
To update the snapshots:
🧬 QA & Testing