Omit migration to @Setter annotated field of other annotations are present

[MBoegers]

What's changed?

• Reported in Recipe UseLombokSetter deletes setter if annotations are present rewrite#5015 the Lombok recipes don't migrate other annotations.

What's your motivation?

prevent breaking changes

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Best to use the annotation service here as there might also be annotations on the return type for instance. Leading annotations only has a limited view on annotations.

[MBoegers]

We don't have a cursor here, it is a util outside a recipe.
2 options I see:

1. accept and note for final fix
2. move the check into recipe as additional check

[knutwannheden]

As LombokUtils is private it should be possible to add a Cursor parameter, right?

[MBoegers]

Refactored it in, I don't know if it is the right thing to do considering it's just a fix not a final solution ;)

[MBoegers]

@timtebeek @knutwannheden The CI is failing because of missing type information at @AllArgsConstructor annotation. May this be a symtom of the changes at Lombok support?

MigrateCollectionsSingletonListTest > lombokAllArgsConstructor() FAILED
    java.lang.IllegalStateException: LST contains missing or invalid type information
    NewClass->EnumValue->EnumValueSet->Block->ClassDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(NewClass type is missing or malformed)~~>*/new(singletonList(FOO))

[timtebeek]

Indeed that's due to Lombok changes in openrewrite/rewrite. I hadn't yet made adjustments here as it seems we're close to a fix upstream. 🙏🏻

[timtebeek]

Great to see, thanks! I've added some slight polish: we tend to retrieve the AnnotationService through a service method defined on the visitor, to prevent repeated instantiation and to allow for instance the Kotlin visitor to swap in an alternative implementation.