Fix Jakarta EE 10 web.xml migration - #1159
Merged
timtebeek merged 1 commit intoJul 8, 2026
Merged
Conversation
timtebeek
reviewed
Jul 1, 2026
Comment on lines
+49
to
+50
| - org.openrewrite.FindSourceFiles: | ||
| filePattern: '**/web.xml' |
Member
There was a problem hiding this comment.
Might this be misplaced? As the precondition here will only match web.xml files, which means none of the ChangeDependency recipes it guards will ever match or make changes.
Member
There was a problem hiding this comment.
Did you intend to add the precondition only to name: org.openrewrite.java.migrate.jakarta.JavaxWebXmlToJakartaWebXml ?
Contributor
Author
There was a problem hiding this comment.
Thanks, you were right. The FindSourceFiles precondition was misplaced and was guarding UpdateJakartaFacesApi3. I moved it to only JavaxWebXmlToJakartaWebXml.
Verified:
UpdateJakartaFacesApiTestJavaxWebXmlToJakartaWebXmlTestJakartaEE10Test
sakshichitnis27
force-pushed
the
fix/7471-jakarta-web-xml-ee10
branch
from
July 8, 2026 10:12
92e420e to
d0b34c5
Compare
timtebeek
approved these changes
Jul 8, 2026
timtebeek
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks a lot for the fix here! Good to keep these files XML to allow chaining recipes.
mergify Bot
added a commit
to robfrank/linklift
that referenced
this pull request
Jul 17, 2026
…37.0 to 3.40.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.37.0 to 3.40.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > 3.40.0 > ------ > > What's Changed > -------------- > > * Keep `\t` and `\f` escapes in UseTextBlocks to avoid incidental whitespace stripping by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1160](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1160) > * Skip UseEnumSetOf empty conversion for static fields to avoid circular class-init ([#1157](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1157)) by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1161](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1161) > * Skip `UseMapOf` for `LinkedHashMap`/`TreeMap` in the prose `put()` form ([#1163](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1163)) by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1165](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1165) > * Skip AddMockitoJavaAgentToMavenSurefirePlugin when agent already configured in build/plugins by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1166](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1166) > * Add RedundantUtf8Charset recipe to drop redundant UTF-8 from Files calls by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1167](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1167) > * Fix Jakarta EE 10 web.xml migration by [`@sakshichitnis27`](https://github.com/sakshichitnis27) in [openrewrite/rewrite-migrate-java#1159](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1159) > > New Contributors > ---------------- > > * [`@sakshichitnis27`](https://github.com/sakshichitnis27) made their first contribution in [openrewrite/rewrite-migrate-java#1159](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1159) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.39.0...v3.40.0> > > 3.39.0 > ------ > > What's Changed > -------------- > > * Make ExtractExplicitConstructorInvocationArguments templates context-free by [`@knutwannheden`](https://github.com/knutwannheden) in [openrewrite/rewrite-migrate-java#1140](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1140) > * Convert Javadoc `<br>` tags to Markdown line breaks by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1142](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1142) > * Preserve angle brackets when converting `@param <T>` to Markdown by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1141](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1141) > * Fix JavadocToMarkdown's handling of varargs and JDKs newer than the bytecode source/target compatibility by [`@sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-migrate-java#1143](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1143) > * Move ReplaceUnusedVariablesWithUnderscore to Java best practices by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1144](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1144) > * Extend Use{List,Set,Map}Of to recognise prose-statement chains by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#1145](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1145) > * Skip `UseMapOf` when the anonymous `HashMap` is assigned to a concrete `HashMap` variable by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1149](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1149) > * Fix jakarta.enterprise.concurrent-api version for EE9 and EE10 by [`@evie-lau`](https://github.com/evie-lau) in [openrewrite/rewrite-migrate-java#1152](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1152) > * Add recipe to replace jakarta jws-api with ws-api in EE10 by [`@evie-lau`](https://github.com/evie-lau) in [openrewrite/rewrite-migrate-java#1151](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1151) > * Upgrade maven-ejb-plugin alongside jakarta.ejb-api by [`@evie-lau`](https://github.com/evie-lau) in [openrewrite/rewrite-migrate-java#1155](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1155) > * Upgrade maven-ear-plugin for ee9 and ee11 by [`@evie-lau`](https://github.com/evie-lau) in [openrewrite/rewrite-migrate-java#1156](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1156) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.38.0...v3.39.0> > > v3.38.0 > ------- > > What's Changed > -------------- > > * use . instead # for FQN link in Markdown javadoc by [`@barbulescu`](https://github.com/barbulescu) in [openrewrite/rewrite-migrate-java#1134](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1134) > * Bump maven-pmd-plugin to 3.28.x for Java 25 support by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1136](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1136) > * Explain why Kotlin modules are capped at Java 24 during Java 25 migration by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1137](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1137) > * Preserve `@{argLine}` in AddSurefireFailsafeArgLine for JaCoCo coverage by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1138](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1138) > * Add recipe to extract complex explicit constructor invocation arguments (JEP 513) by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1135](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1135) > * Bump Kotlin 2.0-2.2 to 2.3 so Kotlin modules can reach Java 25 by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#1139](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/1139) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.37.0...v3.38.0> Commits * [`6584812`](openrewrite/rewrite-migrate-java@6584812) Fix Jakarta EE 10 web.xml migration ([#1159](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1159)) * [`3d0ad8f`](openrewrite/rewrite-migrate-java@3d0ad8f) OpenRewrite recipe best practices * [`76925b9`](openrewrite/rewrite-migrate-java@76925b9) Add RedundantUtf8Charset recipe to drop redundant UTF-8 from Files calls ([#1167](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1167)) * [`c0d0f67`](openrewrite/rewrite-migrate-java@c0d0f67) Skip AddMockitoJavaAgentToMavenSurefirePlugin when agent already configured i... * [`12386c8`](openrewrite/rewrite-migrate-java@12386c8) Skip UseMapOf for LinkedHashMap/TreeMap in prose put-statement form ([#1163](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1163)) (... * [`ee2f4c4`](openrewrite/rewrite-migrate-java@ee2f4c4) OpenRewrite recipe best practices * [`5f18964`](openrewrite/rewrite-migrate-java@5f18964) Skip UseEnumSetOf empty conversion for static fields to avoid circular class-... * [`4cd2123`](openrewrite/rewrite-migrate-java@4cd2123) Keep \t and \f escapes in UseTextBlocks to avoid incidental whitespace stripp... * [`16e662d`](openrewrite/rewrite-migrate-java@16e662d) Upgrade maven-ear-plugin for ee9 and ee11 ([#1156](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1156)) * [`b9f0360`](openrewrite/rewrite-migrate-java@b9f0360) Upgrade maven-ejb-plugin alongside jakarta.ejb-api ([#1155](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/1155)) * Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.37.0...v3.40.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the plain text
FindAndReplacesteps forweb.xmlwith XML-awareChangeTagValuesteps soweb.xmlremains an XML LST. This allows the laterJakartaWebXml6recipe in theJakartaEE10chain to updateweb.xmlfrom version5.0to6.0.Adds a regression test for the
JakartaEE10chain.Verified:
./gradlew test --tests "org.openrewrite.java.migrate.jakarta.JavaxWebXmlToJakartaWebXmlTest"./gradlew test --tests "org.openrewrite.java.migrate.jakarta.JakartaEE10Test"