fix: coverage reporting

[Uzlopak]

Lets see...

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (21832bf) to head (8f37571).
Report is 512 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2763      +/-   ##
==========================================
- Coverage   93.84%   93.80%   -0.05%     
==========================================
  Files          84       84              
  Lines       23184    23199      +15     
==========================================
+ Hits        21758    21762       +4     
- Misses       1426     1437      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Uzlopak]

@KhafraDev

It shows now the coverage correct. Only the mentioned bug in debug.js is now throwing.

[KhafraDev]

let's wait for the test to be fixed/skipped and for the codecov branch to be fixed

[KhafraDev]

codecov didn't update...

[Uzlopak]

@KhafraDev

Independently, this PR can land without fixing codecov.

[KhafraDev]

I don't see the reason in fixing the coverage if the coverage is still "broken". Coverage being on the wrong branch should be fixed before this IMO.

[Uzlopak]

@ronag

Do you have access to this repos secret?

[ronag]

I don't even know what that is 😅

[Uzlopak]

@ronag

Do you have access to https://github.com/nodejs/undici/settings/secrets/actions ?

[ronag]

Yes

[Uzlopak]

Can you go to https://app.codecov.io/github/nodejs/undici/settings and store the token as CODECOV_TOKEN ?
Also storing the CODECOV_TOKEN in https://github.com/Uzlopak/fastify/settings/secrets/dependabot

pretty please, with sugar on top 🥺

[Uzlopak]

@ronag

I see that you made a thumbs up reaction. Did you change it? If so I have to push again to this PR so that I can check if it now can send data to codecov properly

[ronag]

Not yet. I'll fix it tomorrow.

[Uzlopak]

I manually pushed code coverage to codecov. Now it thinks we are at 93%.

Anyhow....

if somebody can please set the code coverage token into this repository secrets, it would be cool.

After setting the token, this PR should be merged.

[ronag]

Can you go to https://app.codecov.io/github/nodejs/undici/settings and store the token as CODECOV_TOKEN ? Also storing the CODECOV_TOKEN in https://github.com/Uzlopak/fastify/settings/secrets/dependabot

pretty please, with sugar on top 🥺

Where/what is "the token"?

[Uzlopak]

Here you can see it as screenshot for my uzlopak/undici fork. So dont use the token from this screenshot

In my screenshot you can see its
CODECOV_TOKEN=71ef5582-e0a8-44b2-a998-c307bb8d97d1

So in the secrets page you would to set for the secret key CODECOV_TOKEN and copy paste 71ef5582-e0a8-44b2-a998-c307bb8d97d1 as value.

Dont you see the correct token when visiting
https://app.codecov.io/github/nodejs/undici/settings ?

Also wrong link in my previous post for the dependabot secrets.
Should be
https://github.com/nodejs/undici/settings/secrets/dependabot

[ronag]

Done

[Uzlopak]

Can somebody please approve and merge?

It should now report correctly to codecov

@ronag
@KhafraDev
@mcollina