Edit showFoldingControls to have a never setting#153764
Merged
Merged
Conversation
Contributor
|
Great job! We still need the decoration to track the updated ranges. Adding @rebornix for reviewing the notebook changes |
aeschli
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #58708
Demo:
vcxsrv_CBxfgCEEuk.mp4
editor.showFoldingControlsandnotebook.showFoldingControlslineDecorationWidthis updated with the settingneverOf consideration:
hiddenone? Does anything depend on the decorations assumed to be there?commentsEditorContributionfor the gutter size but I don't actually know what this does/how to open this "comment editor"