Skip to content

Edit showFoldingControls to have a never setting#153764

Merged
aeschli merged 1 commit into
microsoft:mainfrom
jzyrobert:jzyrobert/editor_folding_never
Jul 7, 2022
Merged

Edit showFoldingControls to have a never setting#153764
aeschli merged 1 commit into
microsoft:mainfrom
jzyrobert:jzyrobert/editor_folding_never

Conversation

@jzyrobert

Copy link
Copy Markdown
Contributor

This PR fixes #58708

Demo:

vcxsrv_CBxfgCEEuk.mp4
  • Add 'never' as a setting with a description to both editor.showFoldingControls and notebook.showFoldingControls
  • Ensure lineDecorationWidth is updated with the setting
  • Don't show visible folding decorations when set to never

Of consideration:

  • Should the setting actually remove the folding decorations instead of using the hidden one? Does anything depend on the decorations assumed to be there?
  • I edited commentsEditorContribution for the gutter size but I don't actually know what this does/how to open this "comment editor"
  • What kind of tests could be added for this?

@aeschli aeschli self-requested a review July 6, 2022 15:01
@aeschli aeschli added this to the July 2022 milestone Jul 6, 2022
@aeschli

aeschli commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Great job!

We still need the decoration to track the updated ranges.
I also tested the editor with comments.

Adding @rebornix for reviewing the notebook changes

@aeschli aeschli requested a review from rebornix July 6, 2022 15:07

@rebornix rebornix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aeschli aeschli merged commit e337c02 into microsoft:main Jul 7, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2022
@jzyrobert jzyrobert deleted the jzyrobert/editor_folding_never branch April 18, 2024 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[folding] editor.showFoldingControls: never

3 participants