Update IJwtBearerService claims type and JwtBearer versions#197
Merged
Conversation
Changed claims parameter to IEnumerable<Claim>? in IJwtBearerService for greater flexibility. Updated obsolete CreateToken to call CreateTokenAsync synchronously. Bumped Microsoft.AspNetCore.Authentication.JwtBearer package versions for .NET 8, 9, and 10 targets.
There was a problem hiding this comment.
Pull request overview
This PR updates the JWT bearer abstractions by broadening the claims parameter type in IJwtBearerService and bumps Microsoft.AspNetCore.Authentication.JwtBearer package versions per target framework.
Changes:
- Updated
IJwtBearerService.CreateToken/CreateTokenAsyncto acceptIEnumerable<Claim>?instead ofIList<Claim>?. - Kept the obsolete
CreateTokenimplementation as a synchronous wrapper overCreateTokenAsync. - Bumped
Microsoft.AspNetCore.Authentication.JwtBearerpackage versions fornet8.0,net9.0, andnet10.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SimpleAuthentication.Abstractions/SimpleAuthentication.Abstractions.csproj | Updates JwtBearer package versions per TFM. |
| src/SimpleAuthentication.Abstractions/JwtBearer/IJwtBearerService.cs | Broadens claims parameter type to IEnumerable<Claim>? on token creation APIs. |
| /// <returns>The JWT bearer token.</returns> | ||
| /// <exception cref="ArgumentException"><paramref name="absoluteExpiration"/> is < DateTime.UtcNow.</exception> | ||
| Task<string> CreateTokenAsync(string userName, IList<Claim>? claims = null, string? issuer = null, string? audience = null, DateTime? absoluteExpiration = null); | ||
| Task<string> CreateTokenAsync(string userName, IEnumerable<Claim>? claims = null, string? issuer = null, string? audience = null, DateTime? absoluteExpiration = null); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed claims parameter to IEnumerable? in IJwtBearerService for greater flexibility. Updated obsolete CreateToken to call CreateTokenAsync synchronously. Bumped Microsoft.AspNetCore.Authentication.JwtBearer package versions for .NET 8, 9, and 10 targets.