Skip to content

Rename yarn build-profiler-cli script to build-cli#6191

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
canova:push-vttmrosyzrmr
Jul 16, 2026
Merged

Rename yarn build-profiler-cli script to build-cli#6191
canova merged 2 commits into
firefox-devtools:mainfrom
canova:push-vttmrosyzrmr

Conversation

@canova

@canova canova commented Jul 16, 2026

Copy link
Copy Markdown
Member

Main | Deploy preview

Every time I need to type it by hand, I get annoyed by how long it is :) It's not a huge thing, as mostly the shells have auto-complete, but still I think it's a nice ergonomic improvement.

@canova
canova requested review from fatadel and mstange July 16, 2026 11:53
@canova canova changed the title Rename yarn build-profiler-cli script to build-cli Rename yarn build-profiler-cli script to build-cli Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.63%. Comparing base (a909fb4) to head (d4b6ff9).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6191      +/-   ##
==========================================
- Coverage   83.64%   83.63%   -0.01%     
==========================================
  Files         346      346              
  Lines       37143    37174      +31     
  Branches    10408    10318      -90     
==========================================
+ Hits        31067    31090      +23     
- Misses       5648     5656       +8     
  Partials      428      428              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel

fatadel commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I was occasionally typing yarn test-all because of that 🤣

@fatadel

fatadel commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I think we could rename publish-profiler-cli -> publish-cli here too, wdyt? Or as a follow-up. That would keep things consistent.
Another note is that we could rename the files too and replace profiler-cli -> cli, eg build-profiler-cli.mjs -> build-cli.mjs.

@canova

canova commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Ah, yeah I think it makes sense to rename the publish-profiler-cli. I'll do it in a bit. But I would prefer to keep the file names for now.

@canova
canova force-pushed the push-vttmrosyzrmr branch from d8f4a0e to 431e645 Compare July 16, 2026 13:30

@fatadel fatadel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

canova added 2 commits July 16, 2026 17:21
Every time I need to type it by hand, I get annoyed by how long it is :)
It's not a huge thing, as mostly the shells have auto-complete, but
still I think it's a nice ergonomic improvement.
@canova
canova force-pushed the push-vttmrosyzrmr branch from 431e645 to d4b6ff9 Compare July 16, 2026 15:21
@canova
canova enabled auto-merge July 16, 2026 15:23
@canova
canova merged commit faaf1a1 into firefox-devtools:main Jul 16, 2026
21 checks passed
@canova canova mentioned this pull request Jul 21, 2026
canova added a commit that referenced this pull request Jul 21, 2026
Changes:

[Sky Ning] Skip preview links for non-main PRs (#6161)
[spokodev] fix(gecko-upgrade): don't crash on a counter with empty
sample_groups (#6160)
[fatadel] Show counter values over time in profiler-cli (#6136)
[Markus Stange] Make profile-conversion snapshots more compact and
meaningful (#6152)
[Markus Stange] More typed arrays: sample + counter times, some
frametable columns (#6139)
[Nazım Can Altınova] Only render a marker url field as a link when the
whole value is a URL (#6163)
[fatadel] Show each counter's owning process in profiler-cli (#6164)
[Nazım Can Altınova] Document the pre-existing thread info and network
JSON schemas in the cli (#6171)
[Markus Stange] Copy column contents in
getRawSamplesTableBuilderFromExisting for consistency (#6168)
[Markus Stange] Convert eligible columns to typed arrays when outputting
from profiler-edit (#6167)
[Markus Stange] Remove unused samples.thread column (#6151)
[Markus Stange] Fixed botched merge which broke 'yarn ts' (#6174)
[Nazım Can Altınova] Add marker handles to `profiler-cli thread network`
(#6172)
[Markus Stange] Update json-slabs 0.3.0 → 0.4.0 (major) (#6176)
[Nazım Can Altınova] Surface network activity across profiler-cli
(#6175)
[Nazım Can Altınova] Add `profile meta` command to profiler-cli (#6177)
[Markus Stange] Allow raw marker table's `startTime` and `endTime`
columns to be Float64Array (#6169)
[nightcityblade] Fix light theme text selection colors (#6186)
[Nazım Can Altınova] Import source map URLs from Chrome DevTools traces
(#6190)
[Nazım Can Altınova] Rename yarn `build-profiler-cli` script to
`build-cli` (#6191)
[Nazım Can Altınova] Migrate husky to version 9 (#6201)
[Nazım Can Altınova] Fix horizontal overflow when the transform
navigator is long (#6199)
[fatadel] Add a 'hexadecimal' marker schema field format (#6197)
[Nazım Can Altınova] Bump source-map to 0.8.0 and remove the old type
workaround (#6202)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (July 21, 2026) (#6209)


And special thanks to our localizers:

fr: parmegiani.thomas
fr: Théo Chevalier
sr: Марко Костић (Marko Kostić)
sv-SE: Luna Jernberg
tr: Grk
zh-CN: Ariel
zh-CN: Olvcpr423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants