Skip to content

Add support to show images in markdown preview. - #9224

Merged
BradWalker merged 1 commit into
apache:masterfrom
Chris2011:feature/markdown-image-support
Feb 24, 2026
Merged

Add support to show images in markdown preview.#9224
BradWalker merged 1 commit into
apache:masterfrom
Chris2011:feature/markdown-image-support

Conversation

@Chris2011

Copy link
Copy Markdown
Contributor

Set missing base to use relative paths for loading images.

With this PR you can see the images that I load from a folder called screenshots on the project root folder.
Before it couldn't find them.

Before:
image

After:
image

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@Chris2011 Chris2011 added enhancement ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Markdown labels Feb 23, 2026
@mbien mbien added this to the NB30 milestone Feb 23, 2026

@lkishalmi lkishalmi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.
Thanks!

@BradWalker

Copy link
Copy Markdown
Member

I'm actively working on updates to the Markdown. So this is a welcome change.

@BradWalker
BradWalker requested review from BradWalker and removed request for BradWalker February 24, 2026 03:21
@Chris2011

Copy link
Copy Markdown
Contributor Author

I'm actively working on updates to the Markdown. So this is a welcome change.

Looking forward to your enhancements :)

@matthiasblaesing matthiasblaesing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only eyeballed this, but looks sane to me. Thank you!

@BradWalker
BradWalker self-requested a review February 24, 2026 19:40
@BradWalker
BradWalker merged commit 9f2f330 into apache:master Feb 24, 2026
30 checks passed
@Chris2011
Chris2011 deleted the feature/markdown-image-support branch February 24, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enhancement Markdown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants