[MGPG-105] [MGPG-108] Make plugin backward compat and update site and doco - #77
Merged
Conversation
michael-o
requested changes
Mar 5, 2024
bmarwell
reviewed
Mar 5, 2024
hboutemy
reviewed
Mar 5, 2024
hboutemy
reviewed
Mar 5, 2024
Document the latest changes. --- https://issues.apache.org/jira/browse/MGPG-108
gnodet
reviewed
Mar 7, 2024
gnodet
approved these changes
Mar 8, 2024
|
Resolve #165 |
|
Resolve #244 |
|
Resolve #165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the latest changes. But also implement Java changes related to agent usage and back compat.
Now we distinguish really (and option is un-deprecated):
useAgentinteractiveMeans to provide secret needed for signing:
useAgent && interactiveuseAgent && !interactive!useAgent && interactive!useAgent && !interactiveFinally,
!bestPracticesprovides existing "pass in passphrase as property" mode as well.As first really means "can we talk to the agent" and second means "can agent pop up pinentry dialogue" for both
signers. In fact, this was the case already in
GpgSigner, butBcSignerconflated the two. As it turns out,gpg-agentalso supports "non interactive" password caching that now both signers make use of.
https://issues.apache.org/jira/browse/MGPG-108
https://issues.apache.org/jira/browse/MGPG-105