Skip to content

Port to maven 4.0.0-rc-4 - #943

Merged
desruisseaux merged 1 commit into
apache:masterfrom
fridrich:maven-4.0.0-rc-4
Jul 2, 2025
Merged

Port to maven 4.0.0-rc-4#943
desruisseaux merged 1 commit into
apache:masterfrom
fridrich:maven-4.0.0-rc-4

Conversation

@fridrich

@fridrich fridrich commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Trivial changes so that the plugin builds against maven 4.0.0-rc-4

Comment thread src/main/java/org/apache/maven/plugin/compiler/SourceDirectory.java Outdated
@desruisseaux

Copy link
Copy Markdown
Contributor

Also need to update the .github/workflows/maven-verify.yml file.

It is a small details, but:

...
includes().stream().map(s -> directory.getFileSystem().getPathMatcher(s))

could be rewritten (for avoiding to invoke the same method many times, and also for shorter syntax):

FileSystem fs = directory.getFileSystem();
...
includes().stream().map(fs::getPathMatcher)

@desruisseaux
desruisseaux merged commit 900c665 into apache:master Jul 2, 2025
26 checks passed
@github-actions github-actions Bot added this to the 4.0.0-beta-3 milestone Jul 2, 2025
@desruisseaux desruisseaux added the dependencies Pull requests that update a dependency file label Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants