Skip to content

[AutoParallel] fix intermediate api pipe hook tuple object bug#75081

Merged
liym27 merged 3 commits into
PaddlePaddle:developfrom
GITD245:pipe_hook
Sep 12, 2025
Merged

[AutoParallel] fix intermediate api pipe hook tuple object bug#75081
liym27 merged 3 commits into
PaddlePaddle:developfrom
GITD245:pipe_hook

Conversation

@GITD245

@GITD245 GITD245 commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

PR Category

Auto Parallel

PR Types

Bug fixes

Description

在使用中层api进行pipeline时,会使用pipe_hook插入在不同的pipe stage之间传输数据的层,当该数据(output)为tuple时,会触发 'tuple' object does not support item assignment;该pr针对tuple output单独处理来解决该bug

@paddle-bot

paddle-bot Bot commented Sep 4, 2025

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter

codecov-commenter commented Sep 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@f38d3cb). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #75081   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         7           
  Branches           ?         0           
===========================================
  Hits               ?         7           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GITD245

GITD245 commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

else:
raise ValueError(
f"output should be a dict of tensors or list of tensors or tensor, but {type(output)}"
f"output should be a dict/tensors/list of tensors/tuple of tensor/tensor, but {type(output)}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行报错,是什么意思 output should be a dict/tensors/list of tensors/tuple of tensor/tensor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pp stage之间传输的值只应该是这几个类型之一

liym27
liym27 previously approved these changes Sep 8, 2025

@liym27 liym27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GITD245

GITD245 commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

3 similar comments
@GITD245

GITD245 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@GITD245

GITD245 commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@GITD245

GITD245 commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@GITD245

GITD245 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

2 similar comments
@GITD245

GITD245 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@GITD245

GITD245 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@liym27 liym27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27 liym27 merged commit 4896838 into PaddlePaddle:develop Sep 12, 2025
103 of 107 checks passed
@GITD245 GITD245 deleted the pipe_hook branch September 12, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants