Skip to content

solve value-src dtype fault#56613

Merged
jeff41404 merged 8 commits into
PaddlePaddle:developfrom
zoooo0820:fix_value_src_dtype_error_in_setitem
Sep 14, 2023
Merged

solve value-src dtype fault#56613
jeff41404 merged 8 commits into
PaddlePaddle:developfrom
zoooo0820:fix_value_src_dtype_error_in_setitem

Conversation

@zoooo0820

@zoooo0820 zoooo0820 commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

PR types

Bug fixes

PR changes

APIs

Description

Pcard-66985

Support case in __setitem__ when dtype of src and value are not same.

@paddle-ci-bot

paddle-ci-bot Bot commented Sep 7, 2023

Copy link
Copy Markdown

Sorry to inform you that b803b41's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zoooo0820 zoooo0820 force-pushed the fix_value_src_dtype_error_in_setitem branch from 12ae53d to 02fa379 Compare September 11, 2023 06:26

@jeff41404 jeff41404 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 594177b into PaddlePaddle:develop Sep 14, 2023
@zoooo0820 zoooo0820 deleted the fix_value_src_dtype_error_in_setitem branch September 14, 2023 10:27
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* solve value-src dtype fault

* support basic-indexing with different dtype, add UT

* skip amp convert when level is O0

* fix ut of amp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants