Skip to content

Marking parallelstore deprecated for gcluster warnings#5325

Merged
vikramvs-gg merged 3 commits into
GoogleCloudPlatform:developfrom
vikramvs-gg:deprecate_parallelstore
Apr 2, 2026
Merged

Marking parallelstore deprecated for gcluster warnings#5325
vikramvs-gg merged 3 commits into
GoogleCloudPlatform:developfrom
vikramvs-gg:deprecate_parallelstore

Conversation

@vikramvs-gg
Copy link
Copy Markdown
Contributor

The Parallelstore module is marked deprecated and its usage is already removed from all our blueprints. Now, that the gcluster deprecation warning feature is in place, we need to configure the deprecation to the module metadata. This change configures the deprecation parameters for parallelstore module.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@vikramvs-gg vikramvs-gg added the release-deprecations Added to release notes under the "Deprecations" heading. label Mar 9, 2026
@vikramvs-gg vikramvs-gg requested review from a team and samskillman as code owners March 9, 2026 10:16
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request formalizes the deprecation of the Parallelstore module within the HPC Toolkit. It updates all relevant documentation to reflect a new deprecation timeline and integrates this information into the module's metadata. This ensures that users are properly informed about the module's end-of-life and are guided towards the recommended alternative, the GCP Managed Lustre module, in line with the new gcluster deprecation warning system.

Highlights

  • Deprecation Date Update: The deprecation date for the Parallelstore module and its storage_type has been updated from October 31, 2026, to June 30, 2026, across relevant README files.
  • Module Metadata Configuration: The parallelstore/metadata.yaml file has been updated to include formal deprecation_date and alternative_module fields under the ghpc section, aligning with the new gcluster deprecation warning feature.
Changelog
  • modules/file-system/gke-storage/README.md
    • Updated the deprecation date for Parallelstore storage_type from October 31, 2026, to June 30, 2026.
  • modules/file-system/parallelstore/README.md
    • Updated the module's deprecation date from October 31, 2026, to June 30, 2026.
  • modules/file-system/parallelstore/metadata.yaml
    • Added deprecation_date field with value 2026-06-30 under the ghpc section.
    • Added alternative_module field with value modules/file-system/managed-lustre under the ghpc section.
Activity
  • No specific activity (comments, reviews, etc.) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly marks the parallelstore module as deprecated by updating its metadata with a deprecation date and a recommended alternative. The corresponding README files for parallelstore and gke-storage have also been updated with the new deprecation date. My review includes one suggestion to improve the documentation in the gke-storage module's README to avoid showcasing a deprecated feature in its main example.

Comment thread modules/file-system/gke-storage/README.md Outdated
@vikramvs-gg vikramvs-gg force-pushed the deprecate_parallelstore branch from 9005b6f to fa172b3 Compare March 10, 2026 12:14
@vikramvs-gg vikramvs-gg requested a review from bytetwin March 10, 2026 12:16
Copy link
Copy Markdown
Contributor

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikramvs-gg vikramvs-gg merged commit f196b2b into GoogleCloudPlatform:develop Apr 2, 2026
14 of 70 checks passed
simrankaurb pushed a commit to simrankaurb/cluster-toolkit that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-deprecations Added to release notes under the "Deprecations" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants