Skip to content

Bugfix/Chroma Metadata#5552

Merged
HenryHengZJ merged 2 commits into
mainfrom
bugfix/Chroma-Metadata
Dec 5, 2025
Merged

Bugfix/Chroma Metadata#5552
HenryHengZJ merged 2 commits into
mainfrom
bugfix/Chroma-Metadata

Conversation

@HenryHengZJ

Copy link
Copy Markdown
Contributor

update Chroma metadata handling with sanitization function

@HenryHengZJ HenryHengZJ linked an issue Dec 5, 2025 that may be closed by this pull request
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @HenryHengZJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a bug fix for Chroma metadata handling by introducing a dedicated sanitization function. The new function ensures that all metadata conforms to ChromaDB's supported types, converting non-primitive values into JSON strings. This update improves the overall compatibility and robustness of the Chroma vector store integration.

Highlights

  • Metadata Sanitization: A new sanitizeMetadata function has been introduced to process all metadata before it is sent to ChromaDB, ensuring type compatibility.
  • Type Compatibility: Complex metadata types such as arrays and objects are now automatically JSON stringified to comply with ChromaDB's requirement for primitive metadata values (boolean, number, string, null).
  • Improved Robustness: This change enhances the stability and reliability of Chroma vector store operations by preventing invalid metadata from causing issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a sanitization function for Chroma metadata to handle unsupported data types. The overall approach is good, but the new sanitizeMetadata function has a bug where it can produce undefined values, which violates Chroma's metadata type constraints. I've provided a detailed comment with a suggested fix to make the sanitization more robust and prevent potential runtime errors.

Comment thread packages/components/nodes/vectorstores/Chroma/core.ts
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@HenryHengZJ HenryHengZJ merged commit 5cdaf3c into main Dec 5, 2025
5 checks passed
davehamptonusa pushed a commit to davehamptonusa/Flowise that referenced this pull request Dec 8, 2025
* update Chroma metadata handling with sanitization function

* Update packages/components/nodes/vectorstores/Chroma/core.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error upserting docs into Chroma - metadata error

1 participant