Google Calendar Tool Missing sendUpdates Parameter#5241
Conversation
|
Can you add this as an option in Tools and NOT default to send all - thanks |
Made the changes, review it once.. |
67680fc to
351d592
Compare
HenryHengZJ
left a comment
There was a problem hiding this comment.
thanks! @kushalbhana did you test if this works? For me, I not sure which external emails to use. I've used my gmail, hotmail, flowise email, all receive notifications prior to this changes
|
@HenryHengZJ I tested again with my Workspace email and an external Gmail account. In both cases, I received the event invitation even before the changes, as you mentioned. After adding the sendUpdates parameter explicitly, it still works correctly. The difference is that without the parameter, Google Calendar API defaults to sendUpdates=none, which in some environments leads to external attendees not getting notifications (as reported in the original issue). With this PR, the behavior becomes explicit and predictable by allowing users to choose all | externalOnly | none instead of relying on the API default. So while it works in our cases, this change mainly ensures consistency and configurability across different setups. |
|
yeah, @aidivas which email did you use, that is not able to receive notification? are you familiar with pulling the source code switch to the branch and test it out? |
|
@HenryHengZJ no time to retest this at the moment. Also not adding my emails in a github report 😉 As it stands, It sends ZERO email notifications outside of the organisation (default send all thats supposed to work) when I use this with any G Workspace emails. Tested with several different external emails same issue. Ive switched to using my n8n GCal MCP in FW as it works fine - sends all required G Cal Notifications. Im using Google Workspace so maybe the G Cal Tools can be tested by FW with Workspace. I also added an update to the other GCal Bug as not working again as again it wont use any other Calendar ID's added to the calendar ID field. I cant reopen that bug but did tag you. The exact same G Cloud project, emails and Calendar IDs work with no issues using G Cal Tools in N8N so theres not any issue with my setup. Both N8N/FW running on the same server using NGINX and docker. Once FW confirm its tested and working with G Workspace, I will organise time to repull and test. |
|
thanks all, merging in |
* Google Calendar Tool Missing sendUpdates Parameter * option in Tools and NOT default to send all
Fixes #5222
When creating or updating calendar events with attendees, email notifications should be sent to all attendees regardless of their email domain.
"all" - Send notifications to all guests (required for external emails)
"externalOnly" - Send notifications only to non-Google Calendar guests
"none" - Don't send notifications