Migration Guide#123
Merged
Merged
Conversation
20 tasks
…nto doc/migration
araffin
marked this pull request as ready for review
October 7, 2020 08:58
Miffyli
reviewed
Oct 7, 2020
Miffyli
reviewed
Oct 7, 2020
Miffyli
reviewed
Oct 7, 2020
Miffyli
reviewed
Oct 7, 2020
Miffyli
reviewed
Oct 7, 2020
Miffyli
reviewed
Oct 7, 2020
Miffyli
reviewed
Oct 11, 2020
Miffyli
reviewed
Oct 11, 2020
Collaborator
|
Just two more comments I could see. After addressing those I think this is good to go finally! |
Miffyli
approved these changes
Oct 11, 2020
Miffyli
left a comment
Collaborator
There was a problem hiding this comment.
If no more changes coming, LGTM!
leor-c
pushed a commit
to leor-c/stable-baselines3
that referenced
this pull request
Nov 12, 2020
* Start migration guide * Update guide * Add comment on RMSpropTFLike plus PPO/A2C migrations * Add note about set/get-parameters * Update migration guide * Update changelog and readme * Update doc + clean changelog * Address comments Co-authored-by: Anssi "Miffyli" Kanervisto <kaneran21@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a first draft of the migration guide. Most of the content is there but it should be probably refined in a follow-up PR before v1.0 release.
Motivation and Context
closes #11
Types of changes
Checklist:
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)Note: we are using a maximum length of 127 characters per line