Skip to content

update default versions for Eclipse Java and Groovy formatters - #2381

Merged
nedtwigg merged 4 commits into
diffplug:mainfrom
jochenberger:update-greclipse
Jan 6, 2025
Merged

update default versions for Eclipse Java and Groovy formatters#2381
nedtwigg merged 4 commits into
diffplug:mainfrom
jochenberger:update-greclipse

Conversation

@jochenberger

Copy link
Copy Markdown
Contributor

No description provided.

@jochenberger

Copy link
Copy Markdown
Contributor Author

See also #2286

@jochenberger

Copy link
Copy Markdown
Contributor Author
java.lang.IllegalArgumentException: Expected endsWith /content.xml but was https://groovy.jfrog.io/artifactory/plugins-release/org/codehaus/groovy/groovy-eclipse-integration/5.6.0/e4.34/content.xml.xz
      at com.diffplug.spotless.extra.groovy.GrEclipseFormatterStepSpecialCaseTest.issue_1657_fixed(GrEclipseFormatterStepSpecialCaseTest.java:41)

🤔

@jochenberger

Copy link
Copy Markdown
Contributor Author

@nedtwigg

nedtwigg commented Jan 6, 2025

Copy link
Copy Markdown
Member

Bummer. My vote is:

  • change this PR to update JDT only
  • one or both of:
    • file bug at Equo about support for content.xml.xz
    • ask Greclipse if they can publish a content.xml, instead of only content.xml.xz
  • once one of those gets resolved, then we can bump Greclipse support again

At least Eclipse signing metadata is consistent again for 4.34! They fixed a ton of SWT on GTK issues since 4.32, so I'm happy to see some parts of the Eclipse project working relatively well.

@jochenberger

Copy link
Copy Markdown
Contributor Author

Sounds good to me. I can take care of that tomorrow (UTC+1).

@nedtwigg

nedtwigg commented Jan 6, 2025

Copy link
Copy Markdown
Member

I just reverted the greclipse bump and updated the changelog. 7.0.0 finally releases today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants