Skip to content

Use SessionData for cache storage - #930

Merged
slawekjaranowski merged 3 commits into
apache:masterfrom
slawekjaranowski:cache-session-scope
Sep 16, 2025
Merged

Use SessionData for cache storage#930
slawekjaranowski merged 3 commits into
apache:masterfrom
slawekjaranowski:cache-session-scope

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

Each Maven session should have a new cache.

Singleton can be shared between executions by Maven Daemon.

@slawekjaranowski slawekjaranowski self-assigned this Sep 12, 2025
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Sep 12, 2025
@slawekjaranowski slawekjaranowski added this to the 3.6.2 milestone Sep 12, 2025
@slawekjaranowski

Copy link
Copy Markdown
Member Author

@cstamas looks like session scope is not working in 3.6.3 ... 🤔

@cstamas

cstamas commented Sep 12, 2025

Copy link
Copy Markdown
Member

Then slighly modify a pattern, and instead of using session scope make cache instance be cached in session.data?

@kwin

kwin commented Sep 12, 2025

Copy link
Copy Markdown
Member

Couldn't we just raise the minimum Maven requirement to 3.9 for enforcer?

@slawekjaranowski slawekjaranowski changed the title Bind cache component to session scope Use SessionData for cache storage Sep 13, 2025
@slawekjaranowski

Copy link
Copy Markdown
Member Author

Couldn't we just raise the minimum Maven requirement to 3.9 for enforcer?

It can be the best and simple way ... but we discuss about 3.8.8 as minimum ....

So now I will use SessionData ...

Each Maven session should have a new cache.

Singleton can be shared between executions by Maven Daemon.
@slawekjaranowski
slawekjaranowski merged commit 27e1f46 into apache:master Sep 16, 2025
26 checks passed
@slawekjaranowski
slawekjaranowski deleted the cache-session-scope branch September 16, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin components lifecycle should be tied to session, not container lifecycle

3 participants