Handling null charset in FileUtils.readLines(File, Charset) - #744
Merged
Conversation
Contributor
Author
|
The issue seems to have originated at dcb09db in version 2.12. We happened to upgrade from 2.11. |
garydgregory
requested changes
May 6, 2025
garydgregory
left a comment
Member
There was a problem hiding this comment.
@ryanmkurtz
Thank you for the PR. Please add a unit test to avoid regressions in the future.
Contributor
Author
|
@garydgregory I added a new test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently upgraded to the latest commons-io and the code where we were passing in null Charsets blew up. The javadoc for this method says null should be handled, and this seems to be how you handle it elsewhere in the file.