Skip to content

[IO-875] CopyDirectoryVisitor ignores fileFilter - #743

Merged
garydgregory merged 3 commits into
apache:masterfrom
pbaumard:IO-875-CopyDirectoryVisitor-ignored-fileFilter
May 5, 2025
Merged

[IO-875] CopyDirectoryVisitor ignores fileFilter#743
garydgregory merged 3 commits into
apache:masterfrom
pbaumard:IO-875-CopyDirectoryVisitor-ignored-fileFilter

Conversation

@pbaumard

@pbaumard pbaumard commented May 4, 2025

Copy link
Copy Markdown
Contributor
  • Fix IO-875
  • Fix javadoc
  • Added assertions for the copied files and to get a 100% coverage

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbaumard
Please do not remove assertions.

@pbaumard
pbaumard requested a review from garydgregory May 5, 2025 08:20
@pbaumard

pbaumard commented May 5, 2025

Copy link
Copy Markdown
Contributor Author

@pbaumard Please do not remove assertions.

I thought at first that those removed assertions were useless since they were flagged by SonarLint (RSPEC-5845 and RSPEC-5863).
I added them back and also added some new assertions to get a 100% coverage.
It could be better to move the equals and hashCode tests to some new method to make the intent clearer. For now I just added some comments.

@garydgregory
garydgregory merged commit 5bcc9a8 into apache:master May 5, 2025
garydgregory added a commit that referenced this pull request May 5, 2025
- Document adding and using
org.apache.commons.io.file.CountingPathVisitor.accept(Path,
BasicFileAttributes) #743
- Added missing Javadoc since tag
- Fix Javadoc comment
- Remove extra blank lines
- Sort members
@garydgregory

Copy link
Copy Markdown
Member

@pbaumard

Thank you for your updates. I merged this PR followed up by some cleanups in git master.

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants