Skip to content

Remove 10GB Cache Size Limit for Cache Service V2#2118

Merged
GhadimiR merged 4 commits into
mainfrom
ghadimir/cache_size_restriction
Aug 21, 2025
Merged

Remove 10GB Cache Size Limit for Cache Service V2#2118
GhadimiR merged 4 commits into
mainfrom
ghadimir/cache_size_restriction

Conversation

@GhadimiR

Copy link
Copy Markdown
Contributor

Remove size limit for individual caches on upload, allow for more specific error codes from results backend.

Copilot AI review requested due to automatic review settings August 13, 2025 13:19
@GhadimiR
GhadimiR requested a review from a team as a code owner August 13, 2025 13:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the 10GB cache size limit for Cache Service V2 and improves error handling by allowing more specific error messages from the results backend.

  • Remove the client-side 10GB cache size validation check that was preventing large cache uploads
  • Add a new FinalizeCacheError exception class for better error categorization
  • Update error handling to display specific error messages from the backend instead of generic ones

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/cache/src/cache.ts Remove size limit validation, add FinalizeCacheError class, improve error message handling
packages/cache/tests/saveCacheV2.test.ts Remove size limit test, add tests for large caches and specific error messages, update mocks
packages/cache/tests/saveCache.test.ts Update mock to include message field for API response consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread packages/cache/__tests__/saveCacheV2.test.ts Outdated
@Link-
Link- self-requested a review August 13, 2025 13:33

@Link- Link- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ship

@GhadimiR
GhadimiR merged commit f58042f into main Aug 21, 2025
16 of 17 checks passed
@GhadimiR
GhadimiR deleted the ghadimir/cache_size_restriction branch August 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants