Skip to content

NPM audit fixes - #2049

Merged
GhadimiR merged 3 commits into
mainfrom
ghadimir/audit_fix
May 8, 2025
Merged

NPM audit fixes#2049
GhadimiR merged 3 commits into
mainfrom
ghadimir/audit_fix

Conversation

@GhadimiR

@GhadimiR GhadimiR commented May 8, 2025

Copy link
Copy Markdown
Contributor

Toolkit audit is failing, bumping some deps to resolve.

Hoisted a couple of transitive dependencies to ensure we're using non-vulnerable versions.

Copilot AI review requested due to automatic review settings May 8, 2025 08:39
@GhadimiR
GhadimiR requested a review from a team as a code owner May 8, 2025 08:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions in the artifact package to address failing NPM audits and resolve vulnerability findings.

  • Bumps @actions/github from v5.1.1 to v6.0.1
  • Replaces @octokit/request-error@^5.0.0 with @octokit/request@^8.4.1 and @octokit/request-error@^5.1.1
Files not reviewed (1)
  • packages/artifact/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

packages/artifact/package.json:44

  • Bumping to @actions/github v6 introduces breaking changes; please add or update tests to verify compatibility with any updated APIs.
"@actions/github": "^6.0.1",

packages/artifact/package.json:50

  • [nitpick] The new @octokit/request dependency isn't referenced in the code; consider removing it or adding intended usage.
"@octokit/request": "^8.4.1",

"@octokit/plugin-request-log": "^1.0.4",
"@octokit/plugin-retry": "^3.0.9",
"@octokit/request-error": "^5.0.0",
"@octokit/request": "^8.4.1",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is new 🤔 where is it coming from?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is just getting hoisted, it was previously still included but now we're specifying a version of it at the top level

"@actions/http-client": "^2.1.0",
"@azure/storage-blob": "^12.15.0",
"@octokit/core": "^3.5.1",
"@octokit/core": "^5.2.1",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big jump, are we sure we're not breaking anything?

@GhadimiR GhadimiR May 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see reviewing the package releases, the majors just drop support for older Node versions that we don't test against anymore.

We can't however go to 6.x.x as that's when this package goes ESM so we'd have significant work involved, but for the time being they are backporting vulnerability fixes to 5.x.x

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some extra confidence, I took these changes into a fork and ran some test workflows, all working as intended.

@GhadimiR
GhadimiR merged commit 8007c1c into main May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants