HtmlUnitNekoDOMBuilder: Fix to allow <form> in <table> children - #548
Closed
atnak wants to merge 3 commits into
Closed
HtmlUnitNekoDOMBuilder: Fix to allow <form> in <table> children#548atnak wants to merge 3 commits into
atnak wants to merge 3 commits into
Conversation
Contributor
Author
|
Here's my local test for this but possibly the tests already in Input: <html>
<body>
<table>
<form></form>
<tbody>
<tr>
</tr>
</tbody>
<form></form>
<script></script>
</table>
<table>
<form></form>
<tr>
</tr>
<form></form>
<script></script>
</table>
</body>
</html>Expected: String[] expected = {
"<?xml version='1.0' encoding='UTF-8'?>",
"<html>",
" <head/>",
" <body>",
" <table>",
" <form>",
" </form>",
" <tbody>",
" <tr>",
" </tr>",
" </tbody>",
" <form>", // Not synthesized <tbody> so these are not moved
" </form>",
" <script>",
" </script>",
" </table>",
" <table>",
" <form>",
" </form>",
" <tbody>",
" <tr>",
" </tr>",
" <form>", // These are moved into synthesized <tbody>
" </form>",
" <script>",
" </script>",
" </tbody>",
" </table>",
" </body>",
"</html>",
"", |
Contributor
Author
|
It looked like |
Member
|
Have merged your fix manually - many thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
<form>in table children just like<script>