HtmlUnitNekoDOMBuilder: Better handling of <form></form> enclosures - #538
Merged
Conversation
atnak
force-pushed
the
form_enclosures
branch
from
December 28, 2022 14:52
0f595d0 to
f363bba
Compare
3 tasks
atnak
force-pushed
the
form_enclosures
branch
from
January 18, 2023 18:14
f363bba to
aed8aec
Compare
atnak
force-pushed
the
form_enclosures
branch
6 times, most recently
from
January 18, 2023 18:44
35b916f to
dc89320
Compare
Member
|
@atnak still a draft or can i merge this? |
Contributor
Author
|
Oh wait I just resumed this today. I'm making tests atm |
atnak
force-pushed
the
form_enclosures
branch
from
January 31, 2023 01:53
dc89320 to
02cd8d2
Compare
atnak
marked this pull request as ready for review
January 31, 2023 01:59
Contributor
Author
|
@rbri Thanks for the wait, this PR is ready for review / merge now. |
atnak
force-pushed
the
form_enclosures
branch
from
January 31, 2023 06:03
02cd8d2 to
7c9ddbc
Compare
atnak
force-pushed
the
form_enclosures
branch
from
January 31, 2023 06:41
7c9ddbc to
1108938
Compare
Member
|
Many thanks - as always. |
Member
|
MalformedHtmlTest now shows some problem - i'm already working on this. |
Member
|
Hope we catch them all - thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
HtmlUnitNekoDOMBuilderfor better handling of<form></form>to fix issues with<input>ownershipHtmlUnitNekoDOMBuilder.addNodeToRightParent()for readability and extensibility