Refactoring: Move Method - #470
Closed
bharatwaaj wants to merge 9 commits into
Closed
Conversation
rbri
reviewed
Mar 28, 2022
rbri
left a comment
Member
There was a problem hiding this comment.
This makes sense for me, can you please
- rebase
- maybe it is a good idea to make the public constructors for the shapes private (because we have the factory methods)
- maybe the retunrn type of the factory methods can be more specific
- have a look at the Shape2D parsePoly stuff, this returns an rect as fallback - maybe not a good ide
Member
|
see my comments above and please make sure this does not include parts of other refactorings |
Member
|
Have done another look at this, and i think the code is correct. The classes in the com.gargoylesoftware.htmlunit.util.geometry packages are plain geometry implementations. Thanks for looking at the code - and sorry for not following your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring: Move Method
Reason for change:
The move method refactoring has been applied here as we parse the fields to determine and fit them onto a circle or a rectangle or a polygon, which is a function that is supposed to be carried on by the respective shapes, and thus a common static parse function was created in Circle, Rectangle and Polygon classes and has been used here.