Extract Method as part of Refactoring

[bharatwaaj]

Refactoring: Extract Method

Reason for change:

The method is a complex method as it performed multiple operations and the method had to be split onto a setupWebClientPage method and could be extracted.

 

Particulars	Details	Comments
Commit Hash	com.gargoylesoftware.htmlunit
Branch Name	asdc-assignment-set-1-extract-method
Branch Link	https://github.com/bharatwaaj/htmlunit/tree/asdc-assignment-set-1-extract-method
PR URL	#464

[rbri]

Hi @bharatwaaj ,
many thanks for this PR. But i will close this. I think there is no real benefit in splitting this method into two. Yes i know there are other opinions around, but i usually look from the maintainers point of view (in this case the new method is private, so the only person seeing this is the maintainer.
There a so many points to discuss on this, but i don't like to do it here. I'm doing professional software development since 1990 and have tried many different ways to do things so i have some experiences and reasons to do so.

Instead of this i have introduces another WebRequest ctor to simplify the code a bit.

Thanks for this - it will be great if you can add your full name to the list of contributors in your next PR.

[bharatwaaj]

Hi, Thanks a ton for this, I will make sure about it the next time. I worked at Verizon for 5 years as a Senior Data Scientist and I am a research student currently at Dalhousie University and we are expected to push code to open source and contribute as part of our research and assignment works. I will find other refactorings and try them out, please let me know if you are looking for something specific in some areas. Thank you very much for the swift response. Thanks! Warm regards, *Bharatwaaj Shankar* *Ph: 86809 92809* [image: Image result for aws solutions architect logo]

…

On Sat, Mar 26, 2022 at 2:00 PM RBRi ***@***.***> wrote: Hi @bharatwaaj <https://github.com/bharatwaaj> , many thanks for this PR. But i will close this. I think there is no real benefit in splitting this method into two. Yes i know there are other opinions around, but i usually look from the maintainers point of view (in this case the new method is private, so the only person seeing this is the maintainer. There a so many points to discuss on this, but i don't like to do it here. I'm doing professional software development since 1990 and have tried many different ways to do things so i have some experiences and reasons to do so. Instead of this i have introduces another WebRequest ctor to simplify the code a bit. Thanks for this - it will be great if you can add your full name to the list of contributors in your next PR. — Reply to this email directly, view it on GitHub <#464 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWY6BU6S5HVPJK7AS3HQBTVB47D5ANCNFSM5RXG7U5A> . You are receiving this because you were mentioned.Message ID: ***@***.***>