Validation of decimal values min and step values in number input - #427
Merged
Conversation
previous validation logic used double as type for the min, max and step values of the number input. But that datatype has potential precision issues especially when using remainder (modulo) operation on it (see https://stackoverflow.com/questions/3227342/modulus-with-doubles-in-java) So the datatype is switched to BigDecimal which allows for exact remainder calculations
thuri
force-pushed
the
HtmlNumberInputValidation
branch
from
December 30, 2021 14:27
ae31563 to
25f1b4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous validation logic used double as type for the min, max and step
values of the number input.
But that datatype has potential precision issues especially when using
remainder (modulo) operation on it
(see https://stackoverflow.com/questions/3227342/modulus-with-doubles-in-java)
So the datatype is switched to BigDecimal which allows for exact
remainder calculations